Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorization of inner types in JSX #6756

Closed
olmobrutall opened this issue Jan 30, 2016 · 5 comments · Fixed by #6798
Closed

Colorization of inner types in JSX #6756

olmobrutall opened this issue Jan 30, 2016 · 5 comments · Fixed by #6798
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@olmobrutall
Copy link

I've found a small issue related to #4835 when using inner types, like Navbar.Header, Navbar.Brand and Navbar.Toggle as defined in https://github.com/flyon/react-bootstrap-typescript-definitions.

The text should be in the same red as the other tags, instead of black.

image

@mhegazy mhegazy added the Bug A bug in TypeScript label Jan 30, 2016
@vladima vladima self-assigned this Jan 31, 2016
@olmobrutall
Copy link
Author

Hoy the same but somehow related is the fact that imported types are not colored as types but as variables.

image

In the foto EntityBase, Lite, Entity, TypeContext, PropertyRoute, etc should all be dark teal instead of black.

Sent from my handy.

@techird
Copy link

techird commented Feb 1, 2016

Can not agree more with @olmobrutall, the imported classes and interfaces are all black, low readability, as well as #5515

@vladima
Copy link
Contributor

vladima commented Feb 1, 2016

fix is submitted, now normal and dotted jsx names should look consistent.
dottednames_jsx.

Re: non-colored imports, this is a different issue and I think it was already filed.

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Feb 2, 2016
@olmobrutall
Copy link
Author

Thanks! I'll follow #5515 for import colorization. Or there's a more appropriate issue?

@mhegazy
Copy link
Contributor

mhegazy commented Feb 2, 2016

#5515 seems like a good place for this issue.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants