Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version not detected correctly #46

Closed
p4xel opened this issue Aug 15, 2024 · 2 comments
Closed

New version not detected correctly #46

p4xel opened this issue Aug 15, 2024 · 2 comments
Assignees
Labels
bug Something isn't working DSM7 Synology DSM 7

Comments

@p4xel
Copy link

p4xel commented Aug 15, 2024

It appears there was a change in 5.json label names.
jq -r '.nas.synology.version' returns Null

After changing version changing part to following it works well

  NewVersion=$(echo "$DistroJson" | jq -r '.nas."Synology (DSM 7)".version')
  NewVersion=$(echo "$NewVersion" | grep -oP '^.+?(?=\-)')
  NewVerDate=$(echo "$DistroJson" | jq -r '.nas."Synology (DSM 7)".release_date')
  NewVerAddd=$(echo "$DistroJson" | jq -r '.nas."Synology (DSM 7)".items_added')
  NewVerFixd=$(echo "$DistroJson" | jq -r '.nas."Synology (DSM 7)".items_fixed')
@michealespinola michealespinola self-assigned this Aug 15, 2024
@michealespinola michealespinola added bug Something isn't working DSM7 Synology DSM 7 labels Aug 15, 2024
@michealespinola
Copy link
Owner

Hi, thanks for submitting a bug report! I can confirm the issue as well as your proposed fix for it. Thank you! I will work on submitting a fixed release shortly.

@michealespinola
Copy link
Owner

Version 4.5.0 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DSM7 Synology DSM 7
Projects
None yet
Development

No branches or pull requests

2 participants