Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popout iframe display #486

Closed
sachnk opened this issue Jan 30, 2024 · 2 comments
Closed

Popout iframe display #486

sachnk opened this issue Jan 30, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@sachnk
Copy link
Contributor

sachnk commented Jan 30, 2024

Describe the bug
When popping out a panel that has an iframe, the popped out window doesn't render the iframe. It also sometimes seems to leave behind a phantom div that has the contents of the iframe. The behavior seems a bit non-deterministic -- sometimes it seems to work.

To Reproduce
Sandbox here. This sandbox makes the following changes: a) Adds a new component called "framed" which simply renders an iframe, and b) Updates panel_1 with component: "framed" and renderer: "always".

Steps to reproduce the behavior:

  1. Go to the sandbox.
  2. Click on the pop-out window button that contains panel 1
  3. See if panel 1 renders the iframe correctly

Expected behavior
Ideally, the iframe works as expected. Given that this is an iframe, I reckon it might be tricky.

Screenshots
popout2

Desktop (please complete the following information):

  • Browser Chrome
  • Version 120.0.6099.234

Additional context
None

@mathuo
Copy link
Owner

mathuo commented Jan 30, 2024

Thanks for the report - this will fix be fixed as a part of the changes in #469.

The always rendering mode currently doesn not work correctly in the Popouts due to the fact that the always rendering mode relies on additional code and behaviours that are not correctly configured when the Popout is created.

@mathuo mathuo added this to the v1.10.0 milestone Feb 8, 2024
@mathuo mathuo added the enhancement New feature or request label Feb 8, 2024
@mathuo
Copy link
Owner

mathuo commented Feb 25, 2024

Released in 1.10.0 https://dockview.dev/

@mathuo mathuo closed this as completed Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants