Handle errors when parsing message

[tapichu]

I'm getting this error sporadically with irc 0.3.2:

2011-11-14T07:32:37+00:00 app[app.1]: /app/node_modules/hubot/node_modules/irc/lib/irc.js:715
2011-11-14T07:32:37+00:00 app[app.1]:     message.command = match[1];
2011-11-14T07:32:37+00:00 app[app.1]:                            ^
2011-11-14T07:32:37+00:00 app[app.1]: TypeError: Cannot read property '1' of null
2011-11-14T07:32:37+00:00 app[app.1]:     at parseMessage (/app/node_modules/hubot/node_modules/irc/lib/irc.js:715:28)
2011-11-14T07:32:37+00:00 app[app.1]:     at /app/node_modules/hubot/node_modules/irc/lib/irc.js:506:27
2011-11-14T07:32:37+00:00 app[app.1]:     at Array.forEach (native)
2011-11-14T07:32:37+00:00 app[app.1]:     at Socket.<anonymous> (/app/node_modules/hubot/node_modules/irc/lib/irc.js:505:15)
2011-11-14T07:32:37+00:00 app[app.1]:     at Socket.emit (events.js:64:17)
2011-11-14T07:32:37+00:00 app[app.1]:     at Socket._onReadable (net.js:671:31)
2011-11-14T07:32:37+00:00 app[app.1]:     at IOWatcher.onReadable [as callback] (net.js:177:10)

And the problem is that match can be null under some circumstances (which I haven't pinned down yet).

// Parse command
match = line.match(/^([^ ]+) +/);
message.command = match[1];

Maybe wrapping https://github.com/martynsmith/node-irc/blob/master/lib/irc.js#L506-513 with an if ( line.trim() != '' ) could fix it?

[martynsmith]

Hmmm, failing that far down in the message parsing strikes me as very odd.

Are you able to give me some connection details to the specific IRC server that's causing those issues (and I'll take a closer look).

Thanks,

[tapichu]

I'm using https://grove.io/

I've been unable to debug it properly because the code is deployed on heroku, but I think I've managed to replicate the error on a consistent basis. Tonight I'll set it up at home, with some console.log statements to see what's going on.

Cheers

[tapichu]

It looks like the problem occurs with the QUIT command, when I close my IRC client. I've tested with Konversation and with Quassel and it's happening with both.

[tapichu]

I ran it at home and the problem is here:

match = line.match(/^([^ ]+) +/);
message.command = match[1];

At this point, line is exactly 'QUIT', with no trailing whitespace, so there's no match and the next line fails because match is null.

[leah]

Hey! I just wanted to let you know that I've added an extra space after the QUIT command. Actually, I've added a space after any command that contains no params or message. I think that should help with the parsing.

[tapichu]

👍