Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traceback after joining network in 0.3.1 #50

Closed
akavlie opened this issue Oct 29, 2011 · 1 comment
Closed

Traceback after joining network in 0.3.1 #50

akavlie opened this issue Oct 29, 2011 · 1 comment

Comments

@akavlie
Copy link
Contributor

akavlie commented Oct 29, 2011

Got this right after joining the network:

/Users/akavlie/node_modules/irc/lib/irc.js:510
                    throw err;
                    ^
TypeError: Cannot read property 'mode' of undefined
    at /Users/akavlie/node_modules/irc/lib/irc.js:157:41
    at Array.forEach (native)
    at Client.<anonymous> (/Users/akavlie/node_modules/irc/lib/irc.js:136:26)
    at Client.emit (events.js:64:17)
    at /Users/akavlie/node_modules/irc/lib/irc.js:507:22
    at Array.forEach (native)
    at Socket.<anonymous> (/Users/akavlie/node_modules/irc/lib/irc.js:504:15)
    at Socket.emit (events.js:64:17)
    at Socket._onReadable (net.js:673:31)
    at IOWatcher.onReadable [as callback] (net.js:177:10)
@martynsmith
Copy link
Owner

This has been fixedin 0.3.2

Half-Shot referenced this issue in matrix-org/node-irc Feb 23, 2019
@Throne3d
Add 671 RPL_WHOISSECURE to codes
e55230d 
Fixes #50.

Per https://www.alien.net.au/irc/irc2numerics.html, this is used in
KineIRCd as 671 RPL_WHOISSECURE and doesn't have a conflicting
definition. Unreal also seems to use this numeric for this command type:
https://github.com/unrealircd/unrealircd/blob/unreal40/include/numeric.h#L372

Accordingly, just add the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martynsmith @akavlie