Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Fuzzy search for unrecognized components #811

Open
austinkelleher opened this issue Aug 22, 2017 · 0 comments
Open

[Proposal] Fuzzy search for unrecognized components #811

austinkelleher opened this issue Aug 22, 2017 · 0 comments
Labels
status:backlog Tasks planned to be worked on type:feature A feature request

Comments

@austinkelleher
Copy link
Member

Currently when using an unrecognized tag, a user is provided an error.

Template:

<hallo/>

Error:

Unrecognized tag: hallo - More details: https://github.com/marko-js/marko/wiki/Error:-Unrecognized-Tag

The user may have either:

  • Made a typo
  • Not realized that the component that they're trying to use isn't in the correct scope

We could use fuzzy search to provide a more clear error message that suggests a component name and whether the component is actually in scope or not:

In scope:

Unrecognized tag: "hello". Did you mean "hello"? - More details: https://github.com/marko-js/marko/wiki/Error:-Unrecognized-Tag

Out of scope:

Unrecognized tag: "hello". Did you mean "hello"? The "hello" tag is not in the available scope of this component. - More details: https://github.com/marko-js/marko/wiki/Error:-Unrecognized-Tag

@austinkelleher austinkelleher added the type:feature A feature request label Aug 22, 2017
@mlrawlings mlrawlings added the status:backlog Tasks planned to be worked on label Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:backlog Tasks planned to be worked on type:feature A feature request
Projects
None yet
Development

No branches or pull requests

2 participants