You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(unsure if misleading documentation counts as a "bug" but it seems fitting)
The hillshade-illumination-direction property is documented as a closed range [0,359] but should actually be a half open range [0,360), because it's a floating point value; 359.5 is a valid value. I saw this while working on maplibre-compose and assumed it only accepts integer degrees, only to check the source code and realize it accepts floats.
Looking at the JSON style spec, I don't think it supports a way to define a half open range with a real number maximum, so it's not actually a trivial fix to the docs.
"doc": "The direction of the light source used to generate the hillshading with 0 as the top of the viewport if `hillshade-illumination-anchor` is set to `viewport` and due north if `hillshade-illumination-anchor` is set to `map`.",
"transition": false,
"sdk-support": {
"basic functionality": {
"js": "0.43.0",
"android": "6.0.0",
"ios": "4.0.0"
}
},
"expression": {
"interpolated": true,
"parameters": [
"zoom"
]
},
"property-type": "data-constant"
},
The text was updated successfully, but these errors were encountered:
Describe the bug
(unsure if misleading documentation counts as a "bug" but it seems fitting)
The
hillshade-illumination-direction
property is documented as a closed range [0,359] but should actually be a half open range [0,360), because it's a floating point value; 359.5 is a valid value. I saw this while working on maplibre-compose and assumed it only accepts integer degrees, only to check the source code and realize it accepts floats.Looking at the JSON style spec, I don't think it supports a way to define a half open range with a real number maximum, so it's not actually a trivial fix to the docs.
maplibre-style-spec/src/reference/v8.json
Lines 6414 to 6435 in 7604485
The text was updated successfully, but these errors were encountered: