Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternatives to ProtocolObject #686

Open
madsmtm opened this issue Dec 30, 2024 · 0 comments
Open

Alternatives to ProtocolObject #686

madsmtm opened this issue Dec 30, 2024 · 0 comments
Labels
A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates enhancement New feature or request question Further information is requested

Comments

@madsmtm
Copy link
Owner

madsmtm commented Dec 30, 2024

I suspect it may be possible for us to basically never need to use ProtocolObject, but instead rely on the compiler to do the work of figuring out which traits are valid for which objects.

I've experimented a bit with #[derive(CoercePointee)] in bb1ae6f, to show that some of it can indeed work through that. If we also changed message sending such that &dyn NSObjectProtocol translates to NonNull<AnyObject>, then using protocol objects would look very, very similar to normal Rust code (methods take &dyn MyProtocol and end up returning Retained<dyn MyProtocol>).

One worry is that the vtable may be included in the final binary, that would have to be thoroughly tested beforehand.

We also need to do a more detailed soundness analysis before all this is over.

Another venue to investigate is the relationship between Message and RefEncode, and if we could possibly make the Message trait be dyn-compatible?

@madsmtm madsmtm added enhancement New feature or request question Further information is requested A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant