Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all customizations if Panel Colorizer is removed from the panel #37

Open
2 tasks
luisbocanegra opened this issue Apr 2, 2024 · 1 comment
Open
2 tasks
Labels
brainstorming enhancement New feature or request help wanted Extra attention is needed

Comments

@luisbocanegra
Copy link
Owner

Currently, removing the widget from the panel leaves the panel in a broken state.

  • Customization is not removed, and this is not what users expect to happen
  • Panel is left in a broken state because it tries to apply things on widget count change, but the widget can no longer reach all other widgets

Possible solution

  • Find a way to detect when the widget has been removed but not confirmed yet and either block it or remove the customization right away
  • If hooking into widget removed but not confirmed is not possible trigger the removal when it is confirmed (possibly with Component.onDestruction signal)
  • Adding it back (cancelling the deletion) is already handled by panel exiting edit mode signal

Possibly required changes
Store all the references to foreground (text, icons...) elements instead of always looping through the panel to find them

@luisbocanegra luisbocanegra added bug Something isn't working help wanted Extra attention is needed brainstorming labels Apr 2, 2024
@luisbocanegra luisbocanegra added enhancement New feature or request and removed bug Something isn't working labels Jun 5, 2024
@luisbocanegra
Copy link
Owner Author

Lowered to enhancement as the button to restore the default appearance actually works. Also because I'm not sure if restoring on remove is worth the effort or possible at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brainstorming enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Backlog
Development

No branches or pull requests

1 participant