Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of generated lucky apps (5000) conflicts with latest Mac release Control Center #704

Closed
matthewmcgarvey opened this issue Dec 2, 2021 · 1 comment · Fixed by #727

Comments

@matthewmcgarvey
Copy link
Member

On the latest release of macOS Monterey, the Control Center app uses port 5000. I remember hearing about this, but I just spent 10 minutes trying to figure out why my lucky app would work for a bit and then I would start getting 403 Forbidden responses. This is not something we can reasonably expect developers to know about, so I think it might be best to change it to something else.

It is defined here

Might be worth noting that browsersync has it's own port of 5001, I believe, and doesn't have problems.

@jwoertink
Copy link
Member

jwoertink commented Dec 2, 2021

wow... 😐 shame on them for using that port... I haven't upgraded yet, but I can see how frustrating that would get real quick if you had no clue what to look for. Should we use 4999? 😂

Also, I saw you linked this https://developer.apple.com/forums/thread/682332 in the discord, so I'll leave it here too.

Edit: After reading more of that thread, and then reading through this list of reserved ports apparently, it's more shame on us... Maybe we use 3000? Looking at that list, it seems there's more products using 5000, and 3000 is geared more towards dev servers.

Another idea could be when booting lucky dev, we check for an existing port in use like we do for browsersync
https://github.com/luckyframework/lucky/blob/34f7b3ac45c2b3153c9930eee2d01b738695a2b0/tasks/watch.cr#L87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants