Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi_select_input does not mark selected options correctly #896

Closed
matthewmcgarvey opened this issue Oct 15, 2022 · 0 comments · Fixed by #897
Closed

multi_select_input does not mark selected options correctly #896

matthewmcgarvey opened this issue Oct 15, 2022 · 0 comments · Fixed by #897

Comments

@matthewmcgarvey
Copy link
Member

if value = field.value
is_selected = value.includes?(option_value.to_s)
bool_attrs << :selected if is_selected
end

It calls .to_s on the option_value but the list of selected options coming from the attribute might be numbers.

The solution is to map the array to string values and compare that way like the single value comparison does

is_selected = option_value.to_s == field.param.to_s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant