Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart repository previous versions #500

Closed
mojtabaimani opened this issue Aug 2, 2021 · 6 comments
Closed

Helm chart repository previous versions #500

mojtabaimani opened this issue Aug 2, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@mojtabaimani
Copy link
Contributor

Describe the bug:
When making a new otomi chart release, it will override the index.yaml file of the chart repository and doesn't keep the previous versions. But it should just append the new version to the current index.yaml.

To Reproduce
Steps to reproduce the behavior:

  1. change the version of the chart in chart/otomi/chart.yaml and push to master
  2. go to branch: gh-pages and look at index.yaml file. You will see only the latest release and not the older ones.

Expected behavior: (a clear and concise description of what you expected to happen)
It should update the index.yaml file with the new release and not creating and replacing a new file.

@mojtabaimani mojtabaimani added the bug Something isn't working label Aug 2, 2021
@mojtabaimani
Copy link
Contributor Author

@dominikatrela
Copy link

@mojtabaimani please create a story out of this and it in backlog

@linode linode deleted a comment from 0-sv Sep 6, 2021
@Morriz
Copy link
Contributor

Morriz commented Sep 6, 2021

@svatwork I removed your link to a chart releaser action issue, as that was unrelated (feature request to overwrite existing release, which should never happen imo).

@0-sv
Copy link
Contributor

0-sv commented Sep 10, 2021

I thought we were using that action, but anyway, I sent a wrong issue, I actually meant this one: helm/chart-releaser-action#70 (ie., chart releases get appended not overwritten).

Edit:

I now see we use that chart action:

      - if: '${{ steps.prereq.outputs.has_changes }}'
        name: Create and publish otomi chart release
        id: chart_release
        uses: helm/[email protected]
        with:
          charts_dir: chart
          charts_repo_url: https://otomi.io/charts/
        env:
          CR_TOKEN: '${{ secrets.GITHUB_TOKEN }}'

My point is that the feature to append instead of overwrite is in progress.

@Morriz
Copy link
Contributor

Morriz commented Sep 13, 2021

@mojtabaimani please create a story out of this and it in backlog

I don't see a story here, but do suggest to talk to the 3rd party software owner and check wether this will be, or is already implemented. After doing so the assignee of this issue should put this either "On hold" with a remark that we're waiting for feedback, or just put this issue "in progress" and configure it correctly.

@mojtabaimani please from now on always work this way. Please don't let 3rd party software quirks end up as an issue that has no next steps.

@j-zimnowoda j-zimnowoda added enhancement New feature or request and removed bug Something isn't working labels Sep 14, 2021
@mojtabaimani mojtabaimani removed their assignment Oct 7, 2021
@j-zimnowoda
Copy link
Contributor

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants