Unchaught Error: Connection failed (webrtc-star)

[oed]

• Version: [email protected] (pretty sure the same error occurs in [email protected])
• Platform: Browser
• Subsystem: See a similar issue in all browsers I've tested.

Type: Bug

Severity: Medium

Description:

While running an ipfs node with a webrtc-star server configured often an Unchaught Error: Connection failed is often thrown. This error occurs if you're using a VPN and try to connect to a browser peer on the same machine. However it also seems to occur when you're unable to connect to peers in other (unknown) scenarios.

It would perhaps be good to have a way to silence these error by setting a log level somewhere. Users don't strictly need to know if a connection to a random peer has failed for whatever reason.

Steps to reproduce the error:

Simply use the html file provided here: https://gist.github.com/oed/8cdabbc75db2a544c46598d065fbc125

For reference: ipfs/js-ipfs#2508

[jacobheun]

Error handling needs to get added / cleaned up in libp2p-webrtc star. In particular, this error is being thrown and uncaught because we're not listening for errors on inbound connections, https://github.com/libp2p/js-libp2p-webrtc-star/blob/v0.18.3/src/listener.js#L56. The underlying Duplex stream is throwing since there is no error listener, it needs to be added so we can log the error.