Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken checkbox styles #11425

Closed
luewolf opened this issue Nov 21, 2024 · 5 comments
Closed

Broken checkbox styles #11425

luewolf opened this issue Nov 21, 2024 · 5 comments
Labels
bug It's a bug

Comments

@luewolf
Copy link

luewolf commented Nov 21, 2024

Operating system

Android

Joplin version

3.2.1

Desktop version info

No response

Current behaviour

This issue was introduced recently, probably in 3.2.1 or 3.2.

Checkbox lists with text that spans multiple lines no longer have the checkbox aligned at the top, making it difficult to see where one task ends and the next begins.

checkbox_align

Also, text highlights (==foo==) are no longer inline elements within checkbox list items, which causes weird spacing issues.

checkbox_highlight

For reference, the words in the second line should be delimited by spaces:

- [ ] So said Midas: ==Mark my words==, I'll have all the gold.
- [ ] foo ==bar== baz

The issue was observed with the "Aritim dark" theme. I do not know if it affects other themes as well.

Expected behaviour

The checkboxes in checkbox lists should be top-aligned when the text spans multiple lines, as it used to be, as the current center-alignment severely impacts readability (and is inconsistent with other kinds of lists to boot!)

Text highlights within checkbox list items should be inline elements like they are everywhere else (including the other kinds of lists).

Logs

No response

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Nov 22, 2024

I'm also experiencing this on the desktop app:
screenshot: checklist items have inline-block content in their bodies

@laurent22 could this be related to 49e86d1?

@laurent22
Copy link
Owner

Oh, right, yes that would be this change. My goal was to ensure that the checkbox is aligned with the line in front of it, but looks like it broke other things

@laurent22
Copy link
Owner

I can't replicate it though - could you post the Markdown you're using please?

@laurent22
Copy link
Owner

Also please try with v3.2.3 since it has a fix for the checkbox vertical alignment

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Nov 22, 2024

I'm using Joplin desktop v3.2.3 on Fedora Linux. I'm able to reproduce the issue with the following Markdown.

- [ ] This `is` a
    test
- [ ] This `is` another<br/>test.

For me, it renders as
screenshot: Codeblock spans multiple lines
in the Markdown viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug
Projects
None yet
Development

No branches or pull requests

3 participants