fix: remove erigon's --chain parameter #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lyfsn <[email protected]>
lyfsn
force-pushed
the
remove-erigon-chain-param
branch
from
7b827eb to
91e4560
Compare
lyfsn
changed the title
|
Looks like indeed erigontech/erigon#9191 has been fixed by erigontech/erigon#9408. Thanks for the fix! |
barnabasbusa
approved these changes
Apr 26, 2024
barnabasbusa
pushed a commit
that referenced
this pull request
May 6, 2024
🤖 I have created a release *beep* *boop* --- ## [3.0.0](2.2.0...3.0.0) (2024-05-06) ### ⚠ BREAKING CHANGES * add mev-rs relay/builder/boost ([#586](#586)) * upcoming file path change in kurtosis upstream ([#582](#582)) ### Features * add apache file server ([#581](#581)) ([205256a](205256a)) * add enr/enode to apache ([#589](#589)) ([b789e17](b789e17)) * add execution client urls to dora config ([#588](#588)) ([2a20d5a](2a20d5a)) * add mev-rs relay/builder/boost ([#586](#586)) ([525a8fb](525a8fb)) * Add peerdas support ([#591](#591)) ([14296ca](14296ca)) * add snooper urls to assertoor config ([#571](#571)) ([87f383f](87f383f)) * allow setting exit ip address ([#584](#584)) ([aabc942](aabc942)) ### Bug Fixes * non-existent field access on error message ([#577](#577)) ([8515d27](8515d27)) * participant redefining global flag ([#573](#573)) ([9139f4b](9139f4b)) * path for shadowforks post kt update ([#585](#585)) ([e0622a7](e0622a7)) * remove erigon's --chain parameter ([#575](#575)) ([02b9c50](02b9c50)) * upcoming file path change in kurtosis upstream ([#582](#582)) ([8d7c4f9](8d7c4f9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erigon will disable discovery when --chain=dev: https://github.com/ledgerwatch/erigon/blob/3323fdc3489d845e9db607ad5ccc2190421b699d/cmd/utils/flags.go#L1322-L1331
So with the current Kurtosis startup parameter, Erigon will not connect to other EL nodes.
Therefore, I propose deleting this --chain parameter in the Starlark script. If users want, they can pass the parameter through the "el_extra_params" configuration.