Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Proposal: remove nginx ingress controller from contrib #1882

Closed
aledbf opened this issue Oct 17, 2016 · 17 comments
Closed

Proposal: remove nginx ingress controller from contrib #1882

aledbf opened this issue Oct 17, 2016 · 17 comments
Labels
area/ingress lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/network Categorizes an issue or PR as relevant to sig-network.

Comments

@aledbf
Copy link
Contributor

aledbf commented Oct 17, 2016

Hi everyone,

I would like to propose moving the nginx ingress controller located in https://github.com/kubernetes/contrib/tree/master/ingress/controllers/nginx.

I'm not sure if this qualifies for the incubation process or just split it out straight into a repo.
This Ingress controller has been maintained for more than 10 months, with active support in the contrib issues and slack.
(I don't have metrics to indicate the numbers of users)

This will help to:

  • remove code from contrib
  • give more visibility in the organization (so people can actually find it)
  • pick up a few more contributors (hopefully)

Releases:

gcr.io/google_containers/nginx-ingress-controller    0.8.3    3f8119a98476    7 weeks ago
gcr.io/google_containers/nginx-ingress-controller    0.8.2    485ae35fc9f4    11 weeks ago
gcr.io/google_containers/nginx-ingress-controller    0.8.1    d272ea9a1e92    3 months ago
gcr.io/google_containers/nginx-ingress-controller    0.8      0496d9e01ef6    3 months ago
gcr.io/google_containers/nginx-ingress-controller    0.7      98e6b4e68a67    4 months ago
gcr.io/google_containers/nginx-ingress-controller    0.62     9972dee1b956    4 months ago
gcr.io/google_containers/nginx-ingress-controller    0.61     edeb93850b71    5 months ago
gcr.io/google_containers/nginx-ingress-controller    0.6      8cbcaaf34045    5 months ago
gcr.io/google_containers/nginx-ingress-controller    0.5      1ae65a65a987    6 months ago
gcr.io/google_containers/nginx-ingress-controller    0.4      7ca49d81084b    6 months ago
gcr.io/google_containers/nginx-third-party           0.4      6ece3bb745ea    6 months ago
gcr.io/google_containers/nginx-third-party           0.3      b33a4ba965e7    7 months ago
aledbf/nginx-third-party                             0.2      97561252656d    8 months ago
aledbf/nginx-third-party                             0.1      3fb253ced003    8 months ago
aledbf/nginx-third-party                             0.0      1fcb6571e70d    10 months ago

Please let me know your thoughts.

Thanks,
Alejandro

@justinsb
Copy link

I think this is a great idea (cc @bprashanth ).

The nginx ingress controller is critical to making ingress work on non-GCE platforms (in particular AWS). Personally I consider it a core part of k8s, given that ingress is in-core. I would be in favor of grandfathering this in to a kubernetes non-incubator repo, given that we would probably otherwise put it into the incubator and graduate it with the 1.5 release.

@bgrant0607
Copy link
Contributor

There is already an issue for this: #1441. See also #762.

@bgrant0607
Copy link
Contributor

It doesn't need to be incubated.

@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 17, 2018
@bgrant0607
Copy link
Contributor

The home is now https://github.com/kubernetes/ingress-nginx, but there are still examples here that should be moved/removed.

@bgrant0607
Copy link
Contributor

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 22, 2018
@bgrant0607
Copy link
Contributor

cc @bowei

@aledbf
Copy link
Contributor Author

aledbf commented Jan 22, 2018

@bgrant0607 the examples were left here because of the existing links in the kubernetes.io doc site.
It should be safe to remove the examples now.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 22, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 22, 2018
@bgrant0607 bgrant0607 added sig/network Categorizes an issue or PR as relevant to sig-network. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jun 2, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 31, 2018
@aledbf
Copy link
Contributor Author

aledbf commented Sep 2, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 1, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 31, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/ingress lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/network Categorizes an issue or PR as relevant to sig-network.
Projects
None yet
Development

No branches or pull requests

5 participants