Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement customizable request timeout. #88

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

Junkern
Copy link
Contributor

@Junkern Junkern commented Sep 5, 2022

What does this do / why do we need it?

People keep opening issues when the HTTP request times out. The timeout was 2 seconds. Now increased to 10 seconds and implemented the possibility to change the timeout value via environment variable.

@coveralls
Copy link

coveralls commented Sep 5, 2022

Pull Request Test Coverage Report for Build 2992988589

  • 8 of 13 (61.54%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 61.894%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/app/install.go 2 3 66.67%
internal/app/app.go 6 10 60.0%
Totals Coverage Status
Change from base Build 2978210420: -0.04%
Covered Lines: 281
Relevant Lines: 454

💛 - Coveralls

@Junkern Junkern merged commit 2b98f8f into main Sep 5, 2022
@Junkern Junkern deleted the feat/configurable_request_timeout branch September 5, 2022 12:00
@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 2992952971

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 12 (58.33%) changed or added relevant lines in 2 files are covered.
  • 13 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 61.894%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/app/install.go 2 3 66.67%
internal/app/app.go 5 9 55.56%
Files with Coverage Reduction New Missed Lines %
internal/app/app.go 13 84.21%
Totals Coverage Status
Change from base Build 2978210420: -0.04%
Covered Lines: 281
Relevant Lines: 454

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants