Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typo in install long command output #104

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

adamdmharvey
Copy link
Contributor

Signed-off-by: Adam Harvey [email protected]

What does this do / why do we need it?

Identified a typo for specific in the install command. Fixed that, and while I was here, just capitalized Terraform as a product name in a few places.

How this PR fixes the problem?

Improves quality.

What should your reviewer look out for in this PR?

Spelling.

Check lists

  • Test passed
  • Coding style (indentation, etc)

Additional Comments (if any)

make test-functional
curl -L https://github.com/gotestyourself/gotestsum/releases/download/v1.8.1/gotestsum_1.8.1_darwin_amd64.tar.gz | tar -zOxf - gotestsum > ./bin/gotestsum-1.8.1 && chmod +x ./bin/gotestsum-1.8.1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 2014k  100 2014k    0     0  3032k      0 --:--:-- --:--:-- --:--:-- 3032k
bin/gotestsum --no-summary=skipped --junitfile dist/test_results/functional/results.xml --jsonfile dist/test_results/functional/results.out --format short-verbose -- -timeout 1m -coverprofile=dist/test_results/functional/coverage.out -covermode atomic -failfast -race -run ^.*$ ./...
EMPTY cmd
EMPTY cmd/m1-terraform-provider-helper
PASS internal/app.TestCreateBuildCommand (0.00s)
PASS internal/app.TestNormalizeSemver (0.00s)
PASS internal/app.TestExtractRepoNameFromUrl (0.00s)
PASS internal/app.TestCloneRepo (13.07s)
PASS internal/app.TestGetProviderData/Should_get_and_parse_JSON_response (0.00s)
PASS internal/app.TestGetProviderData/Should_get_request_timeout_error (2.00s)
PASS internal/app.TestGetProviderData/Should_error_with_mismatched_JSON (0.00s)
PASS internal/app.TestGetProviderData (2.00s)
PASS internal/app.TestCheckoutSourceCode/Should_checkout_source_code_once (17.21s)
PASS internal/app.TestCheckoutSourceCode/Should_checkout_two_versions_of_same_source_code_once (23.00s)
PASS internal/app.TestCheckoutSourceCode (40.21s)
PASS internal/app.TestParseBuildOutputAndGetBinaryOutputPath/Should_parse_correct_output_from_go_build_-o_command (0.00s)
PASS internal/app.TestParseBuildOutputAndGetBinaryOutputPath/Should_parse_correct_output_from_go_install_command (0.00s)
PASS internal/app.TestParseBuildOutputAndGetBinaryOutputPath (0.00s)
PASS internal/app.TestCreateHclBody/Should_create_body_with_one_entry (0.00s)
PASS internal/app.TestCreateHclBody/Should_create_body_with_two_entries (0.00s)
PASS internal/app.TestCreateHclBody/Should_create_body_with_no_constraints (0.00s)
PASS internal/app.TestCreateHclBody (0.00s)
PASS internal/app.TestParseOutputLockfilePath/Should_return_default_path_if_empty (0.00s)
PASS internal/app.TestParseOutputLockfilePath/Should_return_path_if_not_empty (0.00s)
PASS internal/app.TestParseOutputLockfilePath (0.00s)
PASS internal/app.TestGetLockfile/Should_return_default_path_if_not_existent (0.00s)
PASS internal/app.TestGetLockfile/Should_return_path_if_existent (0.00s)
PASS internal/app.TestGetLockfile (0.00s)
PASS internal/app.TestParseHclLockfile/Should_parse_lockfile_with_no_constraints_field (0.00s)
PASS internal/app.TestParseHclLockfile/Should_parse_lockfile_with_all_fields (0.00s)
PASS internal/app.TestParseHclLockfile (0.00s)
PASS internal/app.TestIsTerraformPluginDirExistent/Should_return_true_if_TerraformPluginDir_exists (0.01s)
PASS internal/app.TestIsTerraformPluginDirExistent/Should_return_false_if_TerraformPluginDir_exists (0.01s)
PASS internal/app.TestIsTerraformPluginDirExistent (0.03s)
PASS internal/app.TestNew/Should_create_App_instance_with_correct_paths (0.01s)
PASS internal/app.TestNew (0.01s)
PASS internal/app.TestActivate/Should_activate_on_first_use_(no_directories_present) (0.02s)
PASS internal/app.TestActivate/Should_activate_if_Plugin_Backup_directory_is_present (0.01s)
PASS internal/app.TestActivate/Should_already_be_activated_if_Plugin_directory_is_present (0.01s)
PASS internal/app.TestActivate (0.04s)
PASS internal/app.TestDeactivate/Should_deactivate_on_first_use_(no_directories_present) (0.02s)
PASS internal/app.TestDeactivate/Should_deactivate_if_Plugin_directory_is_present (0.01s)
PASS internal/app.TestDeactivate/Should_already_be_deactivated_if_Plugin_Backup_directory_is_present (0.01s)
PASS internal/app.TestDeactivate (0.04s)
PASS internal/app.TestCheckStatus/Should_return_active_status (0.01s)
PASS internal/app.TestCheckStatus/Should_return_Deactivated_status (0.01s)
PASS internal/app.TestCheckStatus (0.03s)
PASS internal/app.TestListProviders/Should_return_no_output_for_fresh_install (0.01s)
PASS internal/app.TestListProviders/Should_return_correct_output_for_two_"installed"_providers (0.02s)
PASS internal/app.TestListProviders (0.03s)
coverage: 61.5% of statements
PASS internal/app

DONE 46 tests in 65.255s

Which issue(s) does this PR fix?

n/a

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3643054212

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.128%

Totals Coverage Status
Change from base Build 3436754753: 0.0%
Covered Lines: 320
Relevant Lines: 499

💛 - Coveralls

@Junkern Junkern merged commit c2f32ba into kreuzwerker:main Dec 7, 2022
@adamdmharvey adamdmharvey deleted the adamdmharvey/fix-typo branch December 8, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants