Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesnt work with Traktor 3.9 #53

Open
3rr0rt1gg3r opened this issue Sep 26, 2023 · 8 comments
Open

Doesnt work with Traktor 3.9 #53

3rr0rt1gg3r opened this issue Sep 26, 2023 · 8 comments

Comments

@3rr0rt1gg3r
Copy link

Hi,

Can you fix the files, so they work with Traktor 3.9? Thank you for your big work! 🙂

@skymakai
Copy link

I'm also still using your mods. Create a Patreon if you want to... I'd pay a bit for updates keeping your mods working on newer versions of Traktor.

@kokernutz
Copy link
Owner

I'm sorry to break the news but I am unable to work on these anymore as I don't have a D2/S8 style controller anymore. (In fact I am not doing any DJing at the moment.)

If anyone has a spare D2 laying around that they would be willing to send me, I would update the mods to work with the latest version of Traktor. (Provided NI has not broken anything.)

@MrPatben8
Copy link
Contributor

Hey @kokernutz . I do have an S8 and D2. I'd be happy to try and fix the mod myself and put in a pull request. How do you usually go about porting the mod over to a new Traktor version?

@kokernutz
Copy link
Owner

kokernutz commented Sep 27, 2023

In the past I usually diffed the new version's stock QML files against the last version's to see what might have changed. The differences were usually very minor - usually just a small change or two on a model's properties. Then I would just make the appropriate changes to my repo. So in this case you would want to diff the 3.9 files against 3.4.

There may be a smarter/faster way of doing it but I don't what that is.

@derzw3rg
Copy link

derzw3rg commented Oct 9, 2023

@MrPatben8 i've started with a update pull request but i've encountered some problems. maybe you want to take a look at it

@MrPatben8
Copy link
Contributor

@MrPatben8 i've started with a update pull request but i've encountered some problems. maybe you want to take a look at it

@derzw3rg Sure, I can certainly take a look. Can you describe some of these problems?

@derzw3rg
Copy link

@MrPatben8 i've added a comment to the pull request - maybe you are more experienced with qml - this is the first time i work with that language as i mainly work in webdev

@JorgeHontoria
Copy link

I have made many changes to integrate as many community features as possible. Please download the new version (for traktor 3.10.x and 3.11.x) from New Version, try it and let me know if you have any unresolved problems.

Clicking on the star in the Git repository is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants