Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session expired #5

Open
ericmigi opened this issue Jan 13, 2021 · 12 comments
Open

Session expired #5

ericmigi opened this issue Jan 13, 2021 · 12 comments
Labels
bug Something isn't working

Comments

@ericmigi
Copy link

Just started getting this error today

Screenshot_20210113-063001.png

@pidongqianqian
Copy link
Collaborator

there are many reasons for this happening, and its diffcult to reproduce it according you description.

i'll keep this issue open for more details.

@jannis3005
Copy link

jannis3005 commented Feb 18, 2021

I also get this, whenever nothing happens for a few days, e.g. i logged in on thursday, but i didnt send any messages and didnt get any and on sunday i got the session expired message.

@pidongqianqian pidongqianqian added the bug Something isn't working label Feb 19, 2021
@pidongqianqian
Copy link
Collaborator

@jannis3005 thank you for your information, i will fix this, but the priority may not be high

@OttoHollmann
Copy link
Contributor

I had similar issue with expired session after few days/hours, so I set logging: print_level: debug (previously info) and I wanted to upload my logs, but it seems that debug level resolved this issue (at least for me) and my session is still active. So it could resolve @jannis3005 issue.

@Thulinma
Copy link
Contributor

Just to add an extra voice here: I have been unable to keep any session active for > 24h. It looks like it times out both after a 24h period (happened almost exactly 24h after login), and when logging in from a different physical location using (another) skype client.
Is there at least a way to have it auto-relogin..?

@Thulinma
Copy link
Contributor

3 weeks later, I can confirm it's most definitely related to a 24h period after login. I have needed to re-login 21 times in the last 21 days. Is there anything I could do to help debug this?

@pidongqianqian
Copy link
Collaborator

3 weeks later, I can confirm it's most definitely related to a 24h period after login. I have needed to re-login 21 times in the last 21 days. Is there anything I could do to help debug this?

The reason why this is not implemented is that It is not easy to use the existing skpye api to use the existing token to regenerate a new usable token, and the bridge should not save the user's account and password, but if it is only for your own use, you can simply modify some code save yours to achieve it.

@xaionaro
Copy link

I have the same problem: the session expires each 24h.

@kuradikurat
Copy link

Confirming the same behaviour. After 24+ hours sessions tend to expire and require relogin.

@OttoHollmann
Copy link
Contributor

Seems like there is no progress with this issue, right?
I understand that you don't want to store password in database, but I'm afraid, that there is no other way. So what about defining new command LoginPersistent for login and save password or just SavePassword that will store password into database. If user confirm storing his password, there is no problem from my side. Of course we need to modify logout command to erase password from database.

Also we can improve Login command - keep password only in runtime memory. It helps us to regenerate token until bridge will be restarted.

I can implement above changes, but I want to open discussion before doing anything. I really like your bridge, but now it's useless if it's get disconnected every 24 hours.

@OttoHollmann
Copy link
Contributor

I found few free hours so I started to work on above changes. Let's move future discussion about changes into above pull-request.

@OttoHollmann
Copy link
Contributor

Above pull request is ready for testing, please test it and provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants