Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codeforces badge is not working #24

Open
sudiptob2 opened this issue Jun 7, 2022 · 0 comments · May be fixed by #25
Open

codeforces badge is not working #24

sudiptob2 opened this issue Jun 7, 2022 · 0 comments · May be fixed by #25

Comments

@sudiptob2
Copy link

image
sudiptob2 pushed a commit to sudiptob2/CP-Badges that referenced this issue Jun 8, 2022
@sudiptob2-bot
fix: broken codeforces badge.
2214f35 
Codeforces badge was broken due to the change of page layout. CP-Badge was not able to parse the rating properly. The issue has been fixed by using the new codeforces public API which returns JSON formatted data containing users' information. Fix and improvements are pointed out below.

Changes:

- Codeforces API is used to retrieve user's information.

- Unresponsive API exceptions are handled. A [-1, black] is returned.

- conditional statements are simplified.

- Docstring updated for function.

Resolves: kehsihba19#24
@sudiptob2 sudiptob2 linked a pull request Jun 8, 2022 that will close this issue
Open
@Deadrohan19 Deadrohan19 mentioned this issue Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: broken codeforces badge. sudiptob2/CP-Badges
Fixed CF error Deadrohan19/CP-Badges
1 participant
@sudiptob2