-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support canary release #4421
Comments
/assign |
Hi @CharlesQQ, I am very interested in your feature Actually, rather than just implement this feature, I am more interested in how you use canary release strategy by in karmada. Can you share more info with me on how using canary release strategy in karmada? Thanks very much~ |
I believe it's time to push forward with this feature. This is a feature that has been discussed for a long time. |
@chaunceyjiang is there any related issue or meeting notes? |
I agree with this. |
This has nothing to do with karmada, it's related to deployment Annotation, as Annotation‘s value changed, custom controller calculate newRS's replicas and oldRS's Replicas; before deployment synced to member cluster, Annotation's value must be changed by our owner controller, so needed paused sync work feature |
After reading the proposal https://github.com/karmada-io/karmada/pull/5118/files, I have some questions. Using pp/cpp for application-level pauses is OK, but not good enough. |
Hi @zach593 thanks for your feedback. We can continue to iterate on this feature. How do you use PP/CPP now? |
pp/cpp owned by the cluster administrator, the application owners can only touch the workload(resource template). we don't need this pause function at the moment, it's just that I personally have doubts about this design. @XiShanYongYe-Chang |
@zach593 Thanks for your use case. We designed it with this in mind, and we plan to orchestrate applications in the future through the new CRD API. For some current user stories, the suspension field in PP/CPP can meet the requirements. If the field cannot meet the user requirements in the future, the field may be deprecated. |
/close |
#5217 can cover this feature. |
What would you like to be added:
annotationsOverrider
fieldWhy is this needed:
Our canary release strategy is declare by deployment.metedata.annotation, process is controller by our owner custom controller;
So before the latest deployment is synced to member cluster, deployment.metedata.annotation must be set
The text was updated successfully, but these errors were encountered: