Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when analyzing 7z file in ManageCatalogs #78

Open
yaboux opened this issue Jun 6, 2018 · 4 comments
Open

Crash when analyzing 7z file in ManageCatalogs #78

yaboux opened this issue Jun 6, 2018 · 4 comments
Labels

Comments

@yaboux
Copy link

yaboux commented Jun 6, 2018

I am a beginner of Github and can only speak Japanese
so please forgive me if I am impolite

  1. Add a new folder in ManageCatalogs
  2. Start work
  3. QuickViewer crashes when 7z file is included

Setup
Windows10 64bit

@kanryu
Copy link
Owner

kanryu commented Jun 6, 2018

QuickViewer uses 7z lib as static link in official, but this library sometimes does not work properly and sometimes crashes especially when reading the old 7z archive. The cause is unknown :(

7z lib has a very special, strange structure, it is necessary to use separate source code for Windows and Linux, and it is not compatible. It may be better to stop using the static link and dynamically link the official build (dll).

@kanryu kanryu added the bug label Jun 6, 2018
@yaboux
Copy link
Author

yaboux commented Jun 8, 2018

Thanks for the reply.
I can use it for the time being by moving the 7z file when analyzing.
I hope that it can be solved well.

@GitHubRulesOK
Copy link

@kanryu
I have found that version 1.1.1 will close instantly when selecting a .7z whilst browsing with the LH pane
as an example
image
Here I have no problem browsing down to the .png but if I click on the following UniExtract.7z file QuickViewer will close instantly

@kanryu
Copy link
Owner

kanryu commented Aug 6, 2018

@GitHubRulesOK The matter is the same cause as the content pointed out by yaboux.

7z lib has a special structure, it builds as dll or it does not work properly unless it compiles all source code of 7z lib at once (can not make static library)

In the Windows version of QuickViewer, static linking is done with a dedicated hack, but it may be a problem. Next time I'll dynamically link and run the official dll of 7z.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants