Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create jvm-profiling-tools/jbang-catalog #19

Closed
maxandersen opened this issue Jan 10, 2024 · 4 comments
Closed

create jvm-profiling-tools/jbang-catalog #19

maxandersen opened this issue Jan 10, 2024 · 4 comments
Labels
wontfix This will not be worked on

Comments

@maxandersen
Copy link
Contributor

At the moment we have jbang aliases for jvm-profling-tools/ap-loader with a jbang-catalog.

Means that you need to do jbang <alias>@jvm-profiling-tools/ap-loader for everything.

If there was a jvm-profling-tools/jbang-catalog repo we could shorten this to just: jbang <alias>@jvm-profiling-tools

shorter and easier to remember imo.

wdyt?

@parttimenerd
Copy link
Member

@jvm-profiling-tools/administrators what do you think? I don't have a problem with it.

@apangin
Copy link
Member

apangin commented Jan 13, 2024

IIUC, you propose creating a separate repository under jvm-profiling-tools org to hold jbang aliases for jattach, async-profiler and related tools.

I'm always happy to see more ways to facilitate adoption of async-profiler and friends, however, I find it a bit confusing to do it this way. If we are talking about accessing profiler commands via jbang, isn't it counterintuitive to connect them through an external location, which is neither a home for jbang nor for the profiler? Currently, jbang-catalog is at least tied with ap-loader that provides those commands. But when it becomes a separate repository, it will no longer be tightly connected with the project, making maintenance unobvious and complicated.

@parttimenerd
Copy link
Member

Good point. I'll close this issue.

@parttimenerd parttimenerd added the wontfix This will not be worked on label Jan 15, 2024
@maxandersen
Copy link
Contributor Author

Just note - the maintanence is close to zero as the alias point to the latest.

If there ever was a need to maintain more often it could be easily automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants