Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a monorepo with a JupyterLab extension #77

Merged
merged 20 commits into from
Feb 3, 2023

Conversation

hbcarlos
Copy link
Member

@hbcarlos hbcarlos commented Jan 30, 2023

TODO:

  • Clean up packages
  • Fix/update GitHub action
  • Setup Lerna
  • Create a lab extension
  • Bring in the remaining plugins
    • Register YDrive
    • File browser with YDrive

Problems

Version

  • JavaScript and Python packages have different versions

TODO in a follow-up PR

@fcollonval, am I missing something?

@hbcarlos hbcarlos marked this pull request as draft January 30, 2023 16:22
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (69d2b70) compared to base (a54d09f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #77   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines        288     290    +2     
=====================================
- Misses       288     290    +2     
Impacted Files Coverage Δ
jupyterlab_rtc/__init__.py 0.00% <0.00%> (ø)
jupyterlab_rtc/app.py 0.00% <0.00%> (ø)
jupyterlab_rtc/handlers.py 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos your plan - including the follow-up PRs - sounds good.

jupyterlab_rtc/_version.py Outdated Show resolved Hide resolved
lerna.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/docprovider/jest.config.js Show resolved Hide resolved
packages/docprovider/tsconfig.json Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
scripts/bump_version.py Outdated Show resolved Hide resolved
@hbcarlos
Copy link
Member Author

hbcarlos commented Feb 2, 2023

Hi @blink1073, sorry for pinging you, but we can not figure out why the check-release workflow doesn't work.

I'm trying to set up the releaser for this repo, a mono-repo JupyterLab extension with a server extension.
There is an error with the check-npm step, saying that some files are missing. See: https://github.com/jupyter-server/jupyter_server_ydoc/actions/runs/4077425029/jobs/7026431557#step:5:1038

The build-npm step does not include all the files. It is missing the lib and src folders. See:
https://github.com/jupyter-server/jupyter_server_ydoc/actions/runs/4077425029/jobs/7026431557#step:5:940

I tried it locally, and it works as expected.

The only weird thing I saw is when building the python package hatch build, the tarball dist/jupyterlab_rtc-4.0.0a18.tar.gz includes everything except for the folder packages. Renaming that folder to something else will fix that.

Do you know what could be wrong?

@fcollonval fcollonval added the enhancement New feature or request label Feb 3, 2023
@fcollonval
Copy link
Member

@blink1073 I tried to debug this one. The conclusion is that the npm build command is not run inside the releaser copy but in the code repository.

Do you know want may be the cause of that?

@fcollonval fcollonval marked this pull request as ready for review February 3, 2023 15:10
@fcollonval fcollonval merged commit df7a73c into jupyterlab:main Feb 3, 2023
@hbcarlos
Copy link
Member Author

hbcarlos commented Feb 3, 2023

Thanks Fred!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants