Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the interface switcher widget #7137

Open
brichet opened this issue Nov 2, 2023 · 0 comments
Open

Change the interface switcher widget #7137

brichet opened this issue Nov 2, 2023 · 0 comments

Comments

@brichet
Copy link
Collaborator

brichet commented Nov 2, 2023

Problem

The interface switcher widget is currently a MenuBar widget (from Lumino) with only one first level item (Open with...).
The MenuBar widget catches the left and right arrow keys event, to move from one menu item to an other (in this case nothing happen since there is only one item).
This behavior breaks attempt to improve accessibility in toolbar by using arrow keys to navigate between items (jupyterlab/jupyterlab#15021 (comment)).

Proposed Solution

Using a select component, more appropriate for a toolbar.

@brichet brichet added enhancement status:Needs Triage Applied to issues that need triage labels Nov 2, 2023
@krassowski krassowski added this to the 7.1 milestone Nov 2, 2023
@RRosio RRosio removed the status:Needs Triage Applied to issues that need triage label Nov 7, 2023
@jtpio jtpio modified the milestones: 7.1, 7.1.x Feb 1, 2024
@jtpio jtpio modified the milestones: 7.1.x, 7.2.x May 1, 2024
@jtpio jtpio modified the milestones: 7.2.x, 7.4.0 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants