Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7: Left-Right sidebar bug /questions ? #6826

Open
Carreau opened this issue Apr 5, 2023 · 7 comments
Open

V7: Left-Right sidebar bug /questions ? #6826

Carreau opened this issue Apr 5, 2023 · 7 comments
Labels
Milestone

Comments

@Carreau
Copy link
Member

Carreau commented Apr 5, 2023

Left Sidebar menu only suggest "Show table of content"top menu with a checkmark ?

The Right sidebar menu suggest Debugger and Notebook Tools.

Should it be just a "Show table of content" top menu, or were the three Notebook Tools, Debugger and TOC supposed to be showable left and right ?

Additionally "Notebook tools" is a blank panel for me. If it's supposed to only show things sometimes, maybe add a placeholder text saying "this will show X, Y, Z, when P1, P2, P3" ?

@Carreau Carreau added the bug label Apr 5, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Apr 5, 2023
@jtpio
Copy link
Member

jtpio commented Apr 5, 2023

Thanks for reporting 👍

Additionally "Notebook tools" is a blank panel for me. If it's supposed to only show things sometimes, maybe add a placeholder text saying "this will show X, Y, Z, when P1, P2, P3" ?

cc @brichet: maybe it's related to the metadata form rework upstream in JupyterLab?

Wondering that we could probably put the notebook tools panel under UI tests like for the Table of Contents to make sure it's displayed correctly?

@jtpio jtpio added this to the 7.0 milestone Apr 5, 2023
@jtpio jtpio removed the status:Needs Triage Applied to issues that need triage label Apr 5, 2023
@brichet
Copy link
Collaborator

brichet commented Apr 5, 2023

cc @brichet: maybe it's related to the metadata form rework upstream in JupyterLab?

Wondering that we could probably put the notebook tools panel under UI tests like for the Table of Contents to make sure it's displayed correctly?

We probably need to add a dependency on @jupyterlab/metadataform if it not already the case.

I can take a look at this.

@jtpio
Copy link
Member

jtpio commented Apr 5, 2023

I can take a look at this.

That would be great, thanks!

@brichet
Copy link
Collaborator

brichet commented Apr 5, 2023

I opened #6834 to fix the notebooktools right panel.

Wondering that we could probably put the notebook tools panel under UI tests like for the Table of Contents to make sure it's displayed correctly?

There were already ui-tests but the blank panels had been pushed as reference snapshots 😄

@jtpio
Copy link
Member

jtpio commented Apr 5, 2023

Should it be just a "Show table of content" top menu, or were the three Notebook Tools, Debugger and TOC supposed to be showable left and right ?

@Carreau some panels should be displayed on the left, others on the right. Some panels might also be added by third-party extensions. So there could be more than one entry for the left sidebar.

@Carreau
Copy link
Member Author

Carreau commented Apr 6, 2023

@Carreau some panels should be displayed on the left, others on the right. Some panels might also be added by third-party extensions. So there could be more than one entry for the left sidebar.

Ok, no worries, feel free to close. It just feel weird to no be able to chose left/right as I had the impression it was possible in JLab.

@jtpio
Copy link
Member

jtpio commented May 15, 2023

It just feel weird to no be able to chose left/right as I had the impression it was possible in JLab.

Switching sidebar side could likely still be implemented. Maybe as part of #6688 so it can be configured via the settings.

Bumping to 7.1.0 to keep it on the radar.

@jtpio jtpio modified the milestones: 7.0, 7.1 May 15, 2023
@jtpio jtpio modified the milestones: 7.1, 7.1.x Feb 1, 2024
@jtpio jtpio modified the milestones: 7.1.x, 7.2.x May 1, 2024
@jtpio jtpio modified the milestones: 7.2.x, 7.4.0 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants