Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading doesn't show the user when the download is complete #232

Closed
ellisonbg opened this issue Oct 30, 2022 · 1 comment · Fixed by #248
Closed

Downloading doesn't show the user when the download is complete #232

ellisonbg opened this issue Oct 30, 2022 · 1 comment · Fixed by #248
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ellisonbg
Copy link
Contributor

Description

When a user clicks on the button to download the job files, the button goes away, but the links don't automatically show up when the files are downloaded. Instead, the user has to hit reload on the list view to get the updated links. To make matters worse, on the detail view, there is no reload button, so the user has to navigate away and come back (if they figure that out).

Once we can depend on Jupyter Server 2, we should use the new event system to trigger view updates, but in the meantime, we should figure out a way for this to work using polling.

Reproduce

  1. Create a job.
  2. Wait for it to finish.
  3. Click on the download job files button.
  4. The links don't show until the user triggers a reload of the view.

Expected behavior

As a user, I want to know that the files are being downloaded and be presented with links when the downloads are ready.

@ellisonbg ellisonbg added the bug Something isn't working label Oct 30, 2022
@ellisonbg ellisonbg added this to the 1.0 Release milestone Oct 30, 2022
@ellisonbg
Copy link
Contributor Author

For now it is fine for us to increase the delay from 500ms to 5s to handle this. But it would be great if we can also show an indicator that the files are downloading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants