-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move jupyter-lsp
package into Jupyter Server org
#805
Comments
👍 I think that we would want to merge PRs: #636, #731, #778 before we start diverging the codebases. #636 would benefit from code review. The remaining two need some finishing up. CI may need some attention as well, we would need to split responsibilities but also there may be regressions to fix. I will have some time this weekend to look at #731, #778 but not sure how far I will get with them. Finally we will want to move issues related to the server side. It could involve moving https://github.com/jupyter-server/jupyter-lsp to https://github.com/jupyter-lsp organisation for half an hour, transferring issues and then moving it back to https://github.com/jupyter-server/. @jtpio did you succeed with this approach with retrolab/notebook or decide not to go for it? |
Yes moving the repo around went quite well and was probably the simplest approach: jupyter/notebook-team-compass#9 (comment) |
Thanks for the insight, I tested the moving process with the current |
Great, @krassowski can you transfer https://github.com/jupyter-server/jupyter-lsp to https://github.com/jupyter-lsp? I can transfer the issues after that. |
@trungleduc are you still interested in extracting out jupyter-lsp out to another repository within jupyter-lsp as we discussed in jupyter-server/team-compass#30? I am still happy to go with this, as long as I get help with transition/rewriting the integration tests so that we do no loose out on this. No worries if not, in that case let's just close this issue and remove the other copy of the repo. Also apologies that I did not reply to your question (but to be fair it was added in an edit so when I read your comment first time I did not see it); unfortunately I do not have rights on jupyter-server so I cannot transfer that repository to jupyter-lsp org. |
Hi @krassowski
Indeed I think this is the way to move forward, it would save maintenance resources. |
What are you trying to do?
Hi @krassowski and @bollwyvl, after our discussion about the server extension package of
jupyterlab-lsp
, we obtained the green light to movejupyter-lsp
into Jupyter Server org. I'm going to extract this package with all commit history and move it to https://github.com/jupyter-server/jupyter-lsp.Please let me know if there is anything I need to take care of before the moving process.
The text was updated successfully, but these errors were encountered: