Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supports_constraint #77

Closed
blegat opened this issue Jan 18, 2020 · 2 comments · Fixed by #86
Closed

supports_constraint #77

blegat opened this issue Jan 18, 2020 · 2 comments · Fixed by #86
Assignees

Comments

@blegat
Copy link
Member

blegat commented Jan 18, 2020

supports_constraint of DualOptimizer simply redirects the same call the the underlying solver. This is incorrect.
Instead, we should have:

@guilhermebodin
Copy link
Collaborator

So let me see if I got this right, we should replace

function MOI.supports_constraint(optimizer::DualOptimizer, F::Type{<:SF}, S::Type{<:SS})
    return MOI.supports_constraint(optimizer.dual_problem.dual_model, F, S)
end

by two functions would those be supports_add_constrained_variable and supports_add_constrained_variables from this PR jump-dev/MathOptInterface.jl#1004?

@blegat
Copy link
Member Author

blegat commented Jan 24, 2020

No, we should keep supports_constraint but replace change its implementation. It should take into account that it dualizes the problem0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants