Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Change: Add external editor options #1958

Open
github2099 opened this issue Nov 17, 2024 · 1 comment
Open

Documentation Change: Add external editor options #1958

github2099 opened this issue Nov 17, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation 📌 This can't go stale ready for pr Okay to start work. Feel free to ask questions.

Comments

@github2099
Copy link

Affected Page(s)

https://jrnl.sh/en/stable/external-editors/

What Could Be Better?

Add gedit
editor: "gedit -w"

Add nano
editor: "nano -Scam"

Other Information

No response

@github2099 github2099 added 🆕 New! documentation Improvements or additions to documentation labels Nov 17, 2024
@micahellison
Copy link
Member

Some notes and thoughts while reviewing this:

  • gedit arg confirmed (-w == -wait)
  • nano is already a blocking process so it shouldn't need any arguments. I can understand why someone would always want to send -Scam to it, but I don't think we should add any arguments there since this page in the docs is specifically about getting editors to work in jrnl.

It could also be worth just listing all known non-blocking editors together. For instance, vim and nvim are also blocking processes and are listed without arguments.

And now that we're listing so many editors, it would be good to alphabetize them rather than appearing to show preference to one or the other. Users are probably just going to use their browser's find feature anyway.

@micahellison micahellison added ready for pr Okay to start work. Feel free to ask questions. 📌 This can't go stale and removed 🆕 New! labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation 📌 This can't go stale ready for pr Okay to start work. Feel free to ask questions.
Projects
None yet
Development

No branches or pull requests

2 participants