Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone Issue: DST cause items on calendar to not show in correct time slot #1083

Closed
quyphan opened this issue Nov 2, 2018 · 3 comments
Closed

Comments

@quyphan
Copy link

quyphan commented Nov 2, 2018

Do you want to request a feature or report a bug?

Bug

What's the current behavior?

If you are going to create an event via the onSelectSlot functionality on Sunday November 4th, 2018 you are going to see a 2 hour offset error. The reason for this is because on November 4th the timezone will change from PDT to PST (daylight savings).

What's the expected behavior?

What is expected is that BigCalendar should automatically detect that on November 4th it should know to adjust from PDT to PST so it does not have a 2 hour offset.

Image:

screen shot 2018-11-02 at 10 17 02 am

As you can see from the example as I am creating an event right now on Sunday November 4th it will have a 2 hour offset. The calendar is showing my 7AM - 9AM event on the 9AM - 11AM grid.

@quyphan
Copy link
Author

quyphan commented Nov 2, 2018

Seems like this is related to #1028

@quyphan quyphan changed the title Timezone Issue: Daylight saving cause items on calendar to not show in correct time slot Timezone Issue: DST cause items on calendar to not show in correct time slot Nov 2, 2018
@quyphan quyphan mentioned this issue Nov 2, 2018
@anna-kartynnik
Copy link
Contributor

@quyphan have you seen #1044 and corresponding PR #1046? I tried to run examples with that fix and event time is the same as slot time on the left.
screen shot 2018-11-02 at 11 45 18

@quyphan
Copy link
Author

quyphan commented Nov 2, 2018

@anna-kartynnik Thanks for fixing this! I showed the before and after in your PR #1046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants