Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyed benchmark comparison #300

Closed
rosenfeld opened this issue Jul 14, 2017 · 3 comments
Closed

Keyed benchmark comparison #300

rosenfeld opened this issue Jul 14, 2017 · 3 comments
Labels
discussion meta News and communication

Comments

@rosenfeld
Copy link

Are there any reasons why hyperapp is only mentioned in the non-keyed section of the referred benchmark in the documentation? It seems hyperapp already supports keyed reconciliation. Is it complicated to update the benchmarks to include HyperApp in the keyed comparison table as well?

https://rawgit.com/krausest/js-framework-benchmark/master/webdriver-ts-results/table.html

@jorgebucaran jorgebucaran added meta News and communication discussion WIP labels Jul 14, 2017
@jorgebucaran
Copy link
Owner

jorgebucaran commented Jul 14, 2017

No particular reason. When I first added it, there was no difference and I was still hoping I could find a good compromise between the two (unkeyed, keyed), but that never happened.

It should be added at some point. Maybe after recycling? #297. 👋

@andyrj
Copy link
Contributor

andyrj commented Jul 14, 2017

When I get js-framework-benchmark running I will send a PR with 0.10.0 in keyed comparison.

@jorgebucaran
Copy link
Owner

jorgebucaran commented Jul 16, 2017

@andyrj Sounds good. Let's do it after we figure out recycling #297.

Added to: #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion meta News and communication
Projects
None yet
Development

No branches or pull requests

3 participants