Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package does not work with Arrays on 1.11 #9

Open
theogf opened this issue Oct 10, 2024 · 2 comments
Open

Package does not work with Arrays on 1.11 #9

theogf opened this issue Oct 10, 2024 · 2 comments

Comments

@theogf
Copy link

theogf commented Oct 10, 2024

Equality functions do not work for arrays on 1.11 due to the new Memory implementation of Array.

Here is a MWE:

julia> x = [1, 2, 3]
3-element Vector{Int64}:
 1
 2
 3

julia> y = [1, 2, 3]
3-element Vector{Int64}:
 1
 2
 3

julia> struct_isapprox(x, y)
false

(which returned true on 1.10)

@theogf
Copy link
Author

theogf commented Oct 10, 2024

Note that this function should not be used on arrays as it just checks that the types are equivalent.

@schlichtanders
Copy link
Member

thanks for pointing this out.

what would you suggest how to deal with it?
sounds to me like the change in behaviour is okay and the implementation of struct_isapprox should rather stay as simple as it is now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants