Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content should not be visible if visible pane prop is false? #251

Closed
johnwalley opened this issue Apr 20, 2022 · 2 comments · Fixed by #271
Closed

Content should not be visible if visible pane prop is false? #251

johnwalley opened this issue Apr 20, 2022 · 2 comments · Fixed by #271
Assignees
@johnwalley
Labels
enhancement New feature or request

Comments

@johnwalley
Copy link
Owner

johnwalley commented Apr 20, 2022 •
edited
Loading

Currently if visible is set to false then the size of the pane is set to 0. However, if the content is larger than the size, it will be visible. For example, the text "Drag view here to display' is visible in this screenshot.

Screenshot 2022-04-20 at 22 22 49

Technically, this could be the concern of the user and they should set a suitable overflow value. Also note, that this is not really about whether the pane is visible, if the content overflows the pane at any size it is an issue. In practice I wonder if it is more ergonomic for Allotment to set overflow hidden and remove the requirement to care about this?
@johnwalley johnwalley changed the title Content should not be visible if visible pane prop is true? Content should not be visible if visible pane prop is false? Apr 20, 2022
@johnwalley johnwalley self-assigned this May 3, 2022
@johnwalley johnwalley added the enhancement New feature or request label May 3, 2022
@johnwalley johnwalley mentioned this issue May 4, 2022
Merged
@Kaishley
Copy link

Hi @johnwalley, when will this fix be released?

@johnwalley
Copy link
Owner Author

Thanks for the nudge. I've just published it as v1.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnwalley johnwalley

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@johnwalley @Kaishley