-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 731: Add new docker template option for container stop timeout #732
Conversation
The test failures are very likely not caused by the PR since the same tests have also been failing for the latest commit on master. |
Thanks for the PR. Re: Can't run unit-tests locally |
I'm going to close this PR, wait a bit, and re-open it to try to get the Jenkins CI build to rebuild it - hopefully it'll build cleanly... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code would benefit from declaring a int
constant of 10
to hold the default timeout, and then reference that everywhere.
If we can't manage to reference it "everywhere" then every declaration of 10 seconds needs a comment (aimed at any future maintainers of this code) saying where else it's defined and the importance of keeping them in step.
At present, we've got it being defaulted to 10 seconds in multiple places but 100 in another - we need to fix that and make that kind of mistake harder to make.
Aside from that, the code changes are nice and neat 😀
src/main/java/com/nirima/jenkins/plugins/docker/DockerTemplate.java
Outdated
Show resolved
Hide resolved
src/main/resources/com/nirima/jenkins/plugins/docker/DockerTemplate/help-stopTimeout.html
Outdated
Show resolved
Hide resolved
e53b350
to
820ac33
Compare
Addresses #731 .