From 70923dbf739933d2ce6e0ed93927d8f428d16633 Mon Sep 17 00:00:00 2001 From: Mason Freed Date: Tue, 28 Jun 2022 11:47:33 +0000 Subject: [PATCH] Bug 1776302 [wpt PR 34570] - Rename showPopup->showPopUp and hidePopup->hidePopUp, a=testonly Automatic update from web-platform-tests Rename showPopup->showPopUp and hidePopup->hidePopUp Per the resolution [1] and associated discussion [2] we need to rename showPopup to showPopUp, and hidePopup to hidePopUp. With the new scheme, the API is the "Pop up API", not the "Popup API". Note that this CL only changes the publicly-visible API from "popup" to "popUp", but leaves many internal references such as kPseudoPopupHidden instead of kPseudoPopUpHidden. crbug.com/1338587 tracks that follow-on work, which I'll do once this change is validated as being web compatible. [1] https://github.com/openui/open-ui/issues/546#issuecomment-1158190204 [2] https://github.com/openui/open-ui/issues/549 Bug: 1307772 Bug: 1338587 Change-Id: Iaa28d4c1b7d526bb0b06c04eaec2fad5d0431746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3717194 Reviewed-by: David Baron Auto-Submit: Mason Freed Commit-Queue: Mason Freed Cr-Commit-Position: refs/heads/main@{#1017676} -- wpt-commits: cd6f245502e992ef25dc2828f91f05a5f7dd689e wpt-pr: 34570 --- .../popup-anchor-nesting.tentative.html | 6 +- ...popup-animated-hide-cleanup.tentative.html | 10 +- ...popup-animated-hide-display.tentative.html | 4 +- ...opup-animated-hide-finishes.tentative.html | 4 +- ...popup-animated-show-display.tentative.html | 2 +- ...opup-animation-corner-cases.tentative.html | 8 +- .../popup-attribute-basic.tentative.html | 30 +++--- .../popup-backdrop-appearance.tentative.html | 6 +- .../popups/popup-defaultopen.tentative.html | 2 +- .../popups/popup-events.tentative.html | 4 +- .../popups/popup-focus.tentative.html | 36 +++---- .../popup-inside-display-none.tentative.html | 2 +- .../popup-invoking-attribute.tentative.html | 8 +- ...pup-light-dismiss-on-scroll.tentative.html | 6 +- .../popups/popup-light-dismiss.tentative.html | 94 +++++++++---------- ...opup-not-keyboard-focusable.tentative.html | 6 +- .../popups/popup-open-display.tentative.html | 2 +- ...p-open-overflow-display-ref.tentative.html | 6 +- ...popup-open-overflow-display.tentative.html | 6 +- .../popups/popup-removal-2.tentative.html | 4 +- .../popups/popup-removal.tentative.html | 2 +- .../popups/popup-shadow-dom.tentative.html | 36 +++---- .../popup-stacking-context.tentative.html | 2 +- .../popups/popup-stacking.tentative.html | 40 ++++---- ...opup-top-layer-interactions.tentative.html | 4 +- .../popups/popup-types.tentative.html | 48 +++++----- 26 files changed, 189 insertions(+), 189 deletions(-) diff --git a/testing/web-platform/tests/html/semantics/popups/popup-anchor-nesting.tentative.html b/testing/web-platform/tests/html/semantics/popups/popup-anchor-nesting.tentative.html index ee903c48ed08e..aa43dd9aea0a6 100644 --- a/testing/web-platform/tests/html/semantics/popups/popup-anchor-nesting.tentative.html +++ b/testing/web-platform/tests/html/semantics/popups/popup-anchor-nesting.tentative.html @@ -14,13 +14,13 @@ -
This is popup 1
- + diff --git a/testing/web-platform/tests/html/semantics/popups/popup-open-overflow-display-ref.tentative.html b/testing/web-platform/tests/html/semantics/popups/popup-open-overflow-display-ref.tentative.html index 7a350ea281dc6..c9f582ce8ffb2 100644 --- a/testing/web-platform/tests/html/semantics/popups/popup-open-overflow-display-ref.tentative.html +++ b/testing/web-platform/tests/html/semantics/popups/popup-open-overflow-display-ref.tentative.html @@ -24,7 +24,7 @@ diff --git a/testing/web-platform/tests/html/semantics/popups/popup-open-overflow-display.tentative.html b/testing/web-platform/tests/html/semantics/popups/popup-open-overflow-display.tentative.html index 32f42dfcea2f0..fd86672566d1c 100644 --- a/testing/web-platform/tests/html/semantics/popups/popup-open-overflow-display.tentative.html +++ b/testing/web-platform/tests/html/semantics/popups/popup-open-overflow-display.tentative.html @@ -38,7 +38,7 @@ diff --git a/testing/web-platform/tests/html/semantics/popups/popup-removal-2.tentative.html b/testing/web-platform/tests/html/semantics/popups/popup-removal-2.tentative.html index 71d420e57988e..7cf0951e5b14b 100644 --- a/testing/web-platform/tests/html/semantics/popups/popup-removal-2.tentative.html +++ b/testing/web-platform/tests/html/semantics/popups/popup-removal-2.tentative.html @@ -17,11 +17,11 @@ const popup = frame1Doc.querySelector('[popup]'); assert_true(!!popup); assert_false(popup.matches(':top-layer')); - popup.showPopup(); + popup.showPopUp(); assert_true(popup.matches(':top-layer')); frame2Doc.body.appendChild(popup); assert_false(popup.matches(':top-layer')); - popup.showPopup(); + popup.showPopUp(); assert_true(popup.matches(':top-layer')); }, 'Moving popup between documents shouldn\'t cause issues'); }; diff --git a/testing/web-platform/tests/html/semantics/popups/popup-removal.tentative.html b/testing/web-platform/tests/html/semantics/popups/popup-removal.tentative.html index b5f8100d04f61..f4df862327680 100644 --- a/testing/web-platform/tests/html/semantics/popups/popup-removal.tentative.html +++ b/testing/web-platform/tests/html/semantics/popups/popup-removal.tentative.html @@ -17,7 +17,7 @@ } const popup = document.querySelector('[popup]'); assert_false(popup.matches(':top-layer')); - popup.showPopup(); + popup.showPopUp(); assert_true(popup.matches(':top-layer')); popup.remove(); // Shouldn't cause any issues document.body.click(); // Shouldn't cause light dismiss problems diff --git a/testing/web-platform/tests/html/semantics/popups/popup-shadow-dom.tentative.html b/testing/web-platform/tests/html/semantics/popups/popup-shadow-dom.tentative.html index b30a92cd09091..95fd3db07d51b 100644 --- a/testing/web-platform/tests/html/semantics/popups/popup-shadow-dom.tentative.html +++ b/testing/web-platform/tests/html/semantics/popups/popup-shadow-dom.tentative.html @@ -36,13 +36,13 @@ ensureShadowDom(testRoot); return findPopups(testRoot); } - function showPopup(testId,popupNum) { - getPopupReferences(testId)[popupNum].showPopup(); + function showPopUp(testId,popupNum) { + getPopupReferences(testId)[popupNum].showPopUp(); }
- +