Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "Online" check #118

Closed
lidel opened this issue Oct 21, 2020 · 0 comments · Fixed by #148
Closed

Improve "Online" check #118

lidel opened this issue Oct 21, 2020 · 0 comments · Fixed by #148
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work

Comments

@lidel
Copy link
Member

lidel commented Oct 21, 2020

While working on #116 I noticed that some gateways aeem to be actively blocking requests for hotlinking images and/or loading .js files, which breaks our existing "Online" check (eg. Cloudflare).

Had no bandwidth to fix that, and additional analysis is required to see if we are able to tell the difference between gateway that is down and one that does not like third party origins fetching data from it.
@lidel lidel added the need/triage Needs initial labeling and prioritization label Oct 21, 2020
@ipfs ipfs deleted a comment from welcome bot Oct 21, 2020
@jessicaschilling jessicaschilling added exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work effort/days Estimated to take multiple days, but less than a week need/analysis Needs further analysis before proceeding and removed need/triage Needs initial labeling and prioritization effort/hours Estimated to take one or several hours labels Oct 26, 2020
@lidel lidel mentioned this issue Jun 8, 2021
Merged
@lidel lidel closed this as completed in #148 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improved origin isolation check ipfs/public-gateway-checker
2 participants
@lidel @jessicaschilling