Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http handler returns 200 OK on command panic #249

Closed
fabiobozzo opened this issue Apr 5, 2024 · 2 comments
Closed

Http handler returns 200 OK on command panic #249

fabiobozzo opened this issue Apr 5, 2024 · 2 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@fabiobozzo
Copy link
Contributor

fabiobozzo commented Apr 5, 2024

My team's fork of Kubo runs on a few custom interface implementations, notably the Pinner.
Recently, we found a bug in one of them which caused a panic, in the context of a command.

We were surprised to find out that the http API returns 200 OK, in case of panic.
In order to demonstrate that behaviour, I opened a PR, with a couple of new http handler tests.
See: #250

@fabiobozzo fabiobozzo added the need/triage Needs initial labeling and prioritization label Apr 5, 2024
Copy link

welcome bot commented Apr 5, 2024

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@lidel
Copy link
Member

lidel commented Apr 16, 2024

Thank you, the remaining work will land in Kubo

@lidel lidel closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants