Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter by category #727

Merged
merged 13 commits into from
Jun 17, 2024
Merged

Conversation

tilucasoli
Copy link
Contributor

@tilucasoli tilucasoli commented Jun 17, 2024

Description

closes #726

  • I added a new type of filter, now it's possible to filter packages by category.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2024

CLA assistant check
All committers have signed the CLA.

@tilucasoli tilucasoli changed the title Filter by category feat: Filter by category Jun 17, 2024
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but overall it looks good!
It's missing docs though, the docs live here:
https://github.com/invertase/melos/blob/main/docs

packages/melos/lib/src/package.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/package.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/package.dart Outdated Show resolved Hide resolved
packages/melos/lib/src/workspace_configs.dart Outdated Show resolved Hide resolved
@tilucasoli tilucasoli requested a review from spydon June 17, 2024 20:02
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

packages/melos/test/package_test.dart Outdated Show resolved Hide resolved
@tilucasoli
Copy link
Contributor Author

tilucasoli commented Jun 17, 2024

I pushed a new commit with an update for the documentation. could you take a look to confirm if it is ok? @spydon

docs/configuration/overview.mdx Outdated Show resolved Hide resolved
docs/filters.mdx Outdated Show resolved Hide resolved
@spydon spydon enabled auto-merge (squash) June 17, 2024 20:58
@spydon spydon merged commit 71bc610 into invertase:main Jun 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: Filter by category
3 participants