fix: updateDependentsVersions disabled with packages still mentioned in changelogs
#719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…and melos version log
mzdm
force-pushed
the
fix/no-dependent-constraints-workspace-changelog
branch
from
e4bdb0d to
7f42a86
Compare
mzdm
changed the title
updateDependentsVersions and updateDependentsConstraints disabled were still mentioned in workspace changelogs and melos versionupdateDependentsVersions disabled still mentioned in changelogs and melos version log
spydon
reviewed
Jun 3, 2024
spydon
reviewed
Jun 4, 2024
mzdm
changed the title
updateDependentsVersions disabled still mentioned in changelogs and melos version logupdateDependentsVersions disabled still mentioned in workspace changelogs and melos version log
Added regression test which fails on main but passes on this branch |
spydon
changed the title
updateDependentsVersions disabled still mentioned in workspace changelogs and melos version logupdateDependentsVersions disabled with packages still mentioned in changelogs
spydon
reviewed
Jun 5, 2024
spydon
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug description: We bumped into this while having automated release to private hosting. Consider package B has dependency on A. If A was updated and we do not want do update constraint in B nor its version (we don't want due excessive publishing because we have fully automated release process), it was still mentioned in
melos versionlog that B is getting bumped and also in the workspace changelog.Fixes #531 - But I think it should check
updateDependentsVersionsand notupdateDependentsConstraintslike in the issue. Because if we update constraint it should not reflect to changelog, right ?Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore