feat: add --line-length option to melos format command
#689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
utamori
changed the title
--line-length option to melos format command--line-length option to melos format command
spydon
reviewed
Apr 2, 2024
…melos into feat/enable-line-length
spydon
previously approved these changes
Apr 2, 2024
| @@ -32,6 +36,7 @@ class FormatCommand extends MelosCommand { | |||
| final setExitIfChanged = argResults?['set-exit-if-changed'] as bool; | |||
| final output = argResults?['output'] as String?; | |||
| final concurrency = int.parse(argResults!['concurrency'] as String); | |||
| final lineLength = int.parse(argResults!['line-length'] as String); | |||
There was a problem hiding this comment.
This needs to accept null too
There was a problem hiding this comment.
I missed it. thanks.
spydon
approved these changes
Apr 2, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a
--line-lengthoption to themelos formatcommand,allowing users to specify the desired line length when formatting Dart code across packages in a Melos workspace.
Type of Change
feat-- New feature (non-breaking change which adds functionality)