Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Default to number of processors for exec concurrency #654

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

MohiuddinM
Copy link
Contributor

Description

This PR removes the hardcoded (5) value of concurrency for exec and replaces it with a dynamic value based on the number of processors in the computer.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just a small formatting change needed

packages/melos/lib/src/command_runner/exec.dart Outdated Show resolved Hide resolved
@MohiuddinM
Copy link
Contributor Author

MohiuddinM commented Mar 10, 2024

Should I change this here too?

concurrency: concurrency,

@spydon
Copy link
Collaborator

spydon commented Mar 10, 2024

Should I change this here too?

concurrency: concurrency,

Here you mean?

Sure, that sounds good!

@spydon spydon changed the title feat: better default value for exec concurrency feat: Default to number of processors for exec concurrency Mar 10, 2024
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for your contribution

@spydon spydon merged commit 43c6ddb into invertase:main Mar 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants