fix: updateGitTagRefs not working for versions like 0.1.2+3 #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fischerscode
commented
Jan 30, 2023
packages/melos/lib/src/package.dart
Outdated
| @@ -107,7 +107,7 @@ RegExp hostedDependencyVersionReplaceRegex(String dependencyName) { | |||
|
|
|||
| RegExp dependencyTagReplaceRegex(String dependencyName) { | |||
| return RegExp( | |||
| '''(?<tag_ref>^\\s+ref\\s?:\\s?)(?<opening_quote>["']?)(?<tag>$dependencyName-v[\\d]+\\.[\\d]+\\.[\\d]+)(?<closing_quote>['"]?)\$''', | |||
| '''(?<tag_ref>^\\s+ref\\s?:\\s?)(?<opening_quote>["']?)(?<tag>$dependencyName-v[\\d]+\\.[\\d]+\\.[\\d]+(?:\\+.*)?)(?<closing_quote>['"]?)\$''', | |||
There was a problem hiding this comment.
I did intentionally use .*. However, one could argue, that \\d+ might be better.
|
@fischerscode Thanks for the contribution! While looking at your PR, I felt we should refactor the code for replacing versions a bit more, fix more edge cases and add tests. Regular expressions are probably not the best approach now that there is |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #455
The expression did not allow the patch version for
0.packages.Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore