Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --dependent-preid option #388

Merged
merged 1 commit into from
Oct 4, 2022
Merged

feat: add --dependent-preid option #388

merged 1 commit into from
Oct 4, 2022

Conversation

blaugold
Copy link
Collaborator

@blaugold blaugold commented Sep 29, 2022

Previously, the preid of dependents was always dev.
Now --preid is used, if provided, unless --dependent-preid is provided.

Fixes #310

Description

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Previously the preid of dependents was always `dev`.
Now it uses `--preid`, if provided, unless `--dependent-preid` is provided.

Fixes #310
@blaugold blaugold requested a review from Salakar September 29, 2022 11:44
@Salakar Salakar merged commit b620136 into main Oct 4, 2022
@Salakar Salakar deleted the blaugold/issue310 branch October 4, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: preid parameter not properly propagated in some cases
2 participants