Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: write conventional commit scopes in changelog #341

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

blaugold
Copy link
Collaborator

@blaugold blaugold commented Jul 4, 2022

Fixes #318

Description

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@Salakar
Copy link
Member

Salakar commented Jul 4, 2022

Would it be possible to have this behind an option in melos.yaml for those that want it but off by default?

For example; we've not been as strict with validating scopes on FlutterFire and wouldn't want these to start appearing and adding unnecessary extra information in the logs 😅

@blaugold
Copy link
Collaborator Author

blaugold commented Jul 4, 2022

Sure, I'll make it opt-in.

@blaugold blaugold merged commit 0c64d61 into main Jul 5, 2022
@blaugold blaugold deleted the blaugold/issue318 branch July 5, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: commit scopes ignored by melos version
2 participants