feat: remove dependency overrides from pubspec_overrides.yaml in melos clean
#290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaugold
changed the title
pubspec_overrides.yaml in melos cleanpubspec_overrides.yaml in melos clean
Salakar
reviewed
May 9, 2022
| final contents = await pubspecOverridesFile.readAsString(); | ||
| final updatedContents = mergeMelosPubspecOverrides({}, contents); | ||
| if (updatedContents != null) { | ||
| await pubspecOverridesFile.writeAsString(updatedContents); | ||
| } |
There was a problem hiding this comment.
I'm not sure but do we want to delete the file here in an else since it's empty and since it was most likely created by Melos?
There was a problem hiding this comment.
mergeMelosPubspecOverrides allows overrides that don't come from melos, so passing in {} does not guarantee that pubspec_overrides.yaml is empty. But we can check for that and if there are no other overrides, then I think it's a good idea to delete the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore