Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ability to refresh token #37

Open
paul opened this issue Jan 19, 2016 · 5 comments
Open

Missing ability to refresh token #37

paul opened this issue Jan 19, 2016 · 5 comments

Comments

@paul
Copy link
Contributor

paul commented Jan 19, 2016

I don't see a way to refresh the OAuth token once it has expired. The #connect_oauth function only accepts the original token, which appears to expire after a few hours. The standard OAuth handshake, and credentials provided by omniauth-heroku include a refresh_token attribute which may be used to automatically obtain a new token one it has expired. It would be nice if this gem accepted the refresh_token as a param (or if it already does, document it somehow. I don't see anything in the gem docs here or in heroic.), and could automatically do the refreshed token exchange.

@geemus
Copy link
Contributor

geemus commented Mar 4, 2016

@paul good point. Do you imagine then that it would catch the request error when it expired, get new token and retry? Would you be up for helping toward a PR? Thanks!

@thebadmonkeydev
Copy link

thebadmonkeydev commented Jan 24, 2018

I'm very interested in this feature, has no one taken it up since last March?

@geemus
Copy link
Contributor

geemus commented Jan 24, 2018

@thebadmonkeydev unfortunately, no progress that I'm aware of.

@thebadmonkeydev
Copy link

The more I look at this the more I feel like it belongs in heroics and not specifically in platform-api. @geemus if you agree I'll open the issue there and start working on a solution.

1 similar comment
@thebadmonkeydev
Copy link

The more I look at this the more I feel like it belongs in heroics and not specifically in platform-api. @geemus if you agree I'll open the issue there and start working on a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants