Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS GuardDuty: Add support for creating filters #9647

Closed
doublefelix7 opened this issue Aug 6, 2019 · 3 comments · Fixed by #14876
Closed

AWS GuardDuty: Add support for creating filters #9647

doublefelix7 opened this issue Aug 6, 2019 · 3 comments · Fixed by #14876
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service.
Milestone

Comments

@doublefelix7
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Terraform aws provider does not currently support the capability to manage filters (CreateFilter, GetFilter, DeleteFilter).
CloudFormation does support this, so this request is to have parity.

New or Affected Resource(s)

  • GuardDuty
  • GuardDuty Filters (example resource name: aws_guardduty_filter)

Potential Terraform Configuration

We could have something like this:

resource "aws_guardduty_filter" "foo" {
   name = "MyFilter"
   description = "Description of MyFilter"
   detector_id = aws_guardduty_detector.id
   rank = 1
   finding_criteria = {
      criterion = {
         updatedAt = {
            Gte = 0
         }
      }
   }
}

References

@doublefelix7 doublefelix7 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 6, 2019
@ghost ghost added the service/guardduty Issues and PRs that pertain to the guardduty service. label Aug 6, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 6, 2019
@phundisk
Copy link

Was going to take a stab at this. Thoughts on the proposal for how the filters aka the criterion might be done?

resource "aws_guardduty_filter" "foo" {
   name = "test_filter"
   description = "This is my description"
   detector_id = "11111111111111"
   rank = 1
   auto_archive = true
   filters = [
     {
       filter_type = "Equal"
       filter_key = "service.action.awsApiCallAction.remoteIpDetails.ipAddressV4"
       filter_values = ["1.1.1.1"]
    }  
   ]
}

@gdavison gdavison self-assigned this Aug 27, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Aug 27, 2020
@gdavison gdavison added this to the v3.5.0 milestone Sep 2, 2020
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service.
Projects
None yet
3 participants