Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: import support for aws_kinesis_firehose_delivery_stream #481

Closed
hashibot opened this issue Jun 13, 2017 · 6 comments
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@hashibot
Copy link

This issue was originally opened by @grep-stripe as hashicorp/terraform#11366. It was migrated here as part of the provider split. The original body of the issue is below.


Terraform Version

terraform -v
Terraform v0.8.4

Affected Resource(s)

aws_kinesis_firehose_delivery_stream

Terraform Configuration Files

The relevant portion of the configuration file.

resource "aws_kinesis_firehose_delivery_stream" "flow_logs_delivery_stream" {
  name        = "flowlogs-kinesis-firehose-s3-stream"
  destination = "s3"

  s3_configuration {
    role_arn   = "${aws_iam_role.firehose_role.arn}"
    bucket_arn = "${aws_s3_bucket.flow_logs_s3_bucket.arn}"
  }
}

Feature Request

Please support terraform import for the aws_kinesis_delivery_stream resource.

$ sc-terraform import aws_kinesis_firehose_delivery_stream.flow_logs_delivery_stream flowlogs-kinesis-firehose-s3-stream
aws_kinesis_firehose_delivery_stream.flow_logs_delivery_stream: Importing from ID "flowlogs-kinesis-firehose-s3-stream"...
Error importing: 1 error(s) occurred:

* import aws_kinesis_firehose_delivery_stream.flow_logs_delivery_stream (id: flowlogs-kinesis-firehose-s3-stream): resource aws_kinesis_firehose_delivery_stream doesn't support import
@hashibot hashibot added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 13, 2017
@docmerlin
Copy link

bump
If state gets messed up, it is annoying to fix without import

@bflad
Copy link
Contributor

bflad commented Dec 21, 2017

I believe this was just resolved in the next provider release by #2082.

@bflad
Copy link
Contributor

bflad commented Jan 12, 2018

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad added this to the v1.7.0 milestone Jan 12, 2018
@bflad
Copy link
Contributor

bflad commented Jan 12, 2018

For anything relating to enhancing the other portions of importing this resource, please open new specific issues. Thanks!

@radeksimko radeksimko added the service/firehose Issues and PRs that pertain to the firehose service. label Jan 15, 2018
@bflad
Copy link
Contributor

bflad commented Jan 18, 2018

v1.7.0 added the initial functionality and v1.7.1 (hopefully releasing tomorrow) will contain important bug fixes for this implementation (#2970, #3052). I'm going to close this issue out now, but please do not hesitate to open new issues with any additional bug reports or other enhancements.

@bflad bflad closed this as completed Jan 18, 2018
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
Development

No branches or pull requests

4 participants